fix(fqdn): allow hyphens in last domain label#1548
Open
alihasan070707 wants to merge 1 commit intogo-playground:masterfrom
Open
fix(fqdn): allow hyphens in last domain label#1548alihasan070707 wants to merge 1 commit intogo-playground:masterfrom
alihasan070707 wants to merge 1 commit intogo-playground:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Summary
The
fqdnvalidator was rejecting valid domain names that contain hyphens in the last label (e.g.test-site-http.test-site), because the TLD character class[a-zA-Z0-9]did not include-.Change
One character added to the last label's character class in
fqdnRegexStringRFC1123:No other parts of the regex were modified.
Test
Added regression case to TestFQDNValidation:
test-site-http.test-site→ valid@go-playground/validator-maintainers