Skip to content

fix: running labelled tasks #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pd93 merged 1 commit into from
Feb 14, 2026
Merged

fix: running labelled tasks #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/models/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export interface Namespace {
// the JSON output from `task --list --json`.
export interface Task {
name: string;
task: string;
desc: string;
summary: string;
// eslint-disable-next-line @typescript-eslint/naming-convention
Expand Down
4 changes: 2 additions & 2 deletions src/models/taskDefinition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export class TaskDefinition implements vscode.TaskDefinition {

// Required to satisfy vscode.TaskDefinition
public get task(): string {
return this._task.name;
return this._task.task;
}

public get name(): string {
Expand All @@ -40,7 +40,7 @@ export class TaskDefinition implements vscode.TaskDefinition {
const task = new vscode.Task(
this,
workspaceFolder,
this.task,
this.name,
this.type,
new vscode.ShellExecution(
`${settings.path} ${this.task}${cliArgs && cliArgs.length > 0 ? " -- " + cliArgs.join(' ') : ''}`,
Expand Down
2 changes: 1 addition & 1 deletion src/providers/taskTreeDataProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export class TaskTreeDataProvider implements vscode.TreeDataProvider<TreeItem> {
for (const task of tasks) {
const definition = new TaskDefinition(task, workspace);
treeItems = treeItems.concat(new TaskTreeItem(
this._nesting ? task.name.split(namespaceSeparator).pop() ?? task.name : task.name,
task.name != "" ? task.name : this._nesting ? task.task.split(namespaceSeparator).pop() ?? task.task : task.task,
workspace,
definition,
vscode.TreeItemCollapsibleState.None,
Expand Down