Expand CP callback context#304
Draft
Powerbyte7 wants to merge 3 commits into
Draft
Conversation
Powerbyte7
force-pushed
the
improve_event_ctx
branch
2 times, most recently
from
86bfec9 to
7666d71
Compare
Powerbyte7
force-pushed
the
improve_event_ctx
branch
from
7666d71 to
43231f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows accessing the CP context from inside CP event handlers, which is useful for querying PD info like the device vendor code. For more details, see #303.
The C implementation is fairly straight-forward. For the C++ implementation I've added a new ControlPanelEventHandler class to avoid having to pass callback data with
void*, give access to ControlPanel instead of osdp_t. This does add some indirection.For now I've only addressed the event callback, but it might be worth modifying other callbacks (logging, command/event completion) as well.