[Windows] Add support for AdvancedColorInfo info and change callback.#118339
[Windows] Add support for AdvancedColorInfo info and change callback.#118339bruvzg wants to merge 1 commit intogodotengine:masterfrom
AdvancedColorInfo info and change callback.#118339Conversation
| //if (WinRTUtils::window_has_display_info(wd.wrt_wd)) { | ||
| // print_line(WinRTUtils::window_get_advanced_color_info(wd.wrt_wd)); | ||
| //} |
There was a problem hiding this comment.
Note: I have added a method to get AdvancedColorInfo as a Godot Dictionary, but not sure if it's needed for something.
bruvzg
force-pushed
the
winrt_color
branch
3 times, most recently
from
9231cbc to
7172109
Compare
|
🤩
Any chance this PR can be updated to include this? Although this PR does solve the problem of the reference luminance not updating until the window regains focus, the real high-priority impetus for this change is to improve performance significantly by not needing to poll for changes in colour space and max luminance. It will also be critically important to test if the |
Derp. My mistake! I think this PR already does this! I'll give this a thorough test. It would be great to have this for 4.7... |
2 participants
See #117837 (comment)
Note: this will not work on Wine and some older Windows 10 versions, so we probably still need to keep polling code for this case, but it can be conditionally skipped (using
WinRTUtils::window_has_display_info).