Change display/window/hdr/request_hdr_output project setting to be a basic setting.#118355
Open
allenwp wants to merge 1 commit intogodotengine:masterfrom
Open
Change display/window/hdr/request_hdr_output project setting to be a basic setting.#118355allenwp wants to merge 1 commit intogodotengine:masterfrom
display/window/hdr/request_hdr_output project setting to be a basic setting.#118355allenwp wants to merge 1 commit intogodotengine:masterfrom
Conversation
…a basic setting.
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
display/window/hdr/request_hdr_outputproject setting because it is hidden by default as an advanced project setting.What is the rationale for the approach used in this PR?
I believe it was an oversight to introduce this project setting as an advanced setting. Also, there has been a massive amount of work to ensure that this feature is extremely safe and easy to use correctly; it is not an advanced feature.
Was AI used to create a portion of this PR?
No.
Are there any parts of this PR that you are uncertain of or require special attention from reviewers?
No.