Fix: Index out of bounds panic in SwaggerUIHandler for files without extension#3217
Open
NitinKumar004 wants to merge 5 commits intogofr-dev:developmentfrom
Open
Fix: Index out of bounds panic in SwaggerUIHandler for files without extension#3217NitinKumar004 wants to merge 5 commits intogofr-dev:developmentfrom
NitinKumar004 wants to merge 5 commits intogofr-dev:developmentfrom
Conversation
…without extension Validate file extension using filepath.Ext before accessing it. Previously, splitting on "." and accessing index [1] would panic for filenames without a dot. Fixes gofr-dev#3214
NitinKumar004
force-pushed
the
fix/swagger-ui-index-out-of-bounds
branch
from
21f8cfb to
f8508c4
Compare
Umang01-hash
requested changes
Apr 7, 2026
pkg/gofr/swagger.go
Outdated
|
|
||
| ext := filepath.Ext(fileName) | ||
| if ext == "" { | ||
| return nil, errMissingFileExtension |
Member
There was a problem hiding this comment.
The error errMissingFileExtension is a plain errors.New(), which GoFr maps to 500 Internal Server Error. A missing file extension is a client error — the request is malformed. It
should return 400 Bad Request or 404 Not Found
…IHandler Replace plain errors.New() with gofrHTTP.ErrorEntityNotFound so the framework correctly maps it to 404 Not Found instead of 500 Internal Server Error. A missing file extension is a client error, not a server error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strings.Split+ direct index access withfilepath.Extto safely extract the file extension.errMissingFileExtension) when the filename has no extension, instead of panicking with index out of bounds.Fixes #3214
Test plan
TestSwaggerUIHandler_NoFileExtensionunit test