fix: logging of unredacted payloads through OperationDescription in audit events#22879
Open
marevers wants to merge 4 commits intogoharbor:mainfrom
Open
fix: logging of unredacted payloads through OperationDescription in audit events#22879marevers wants to merge 4 commits intogoharbor:mainfrom
marevers wants to merge 4 commits intogoharbor:mainfrom
Conversation
Signed-off-by: Martijn Evers <mevers@gk-software.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22879 +/- ##
===========================================
+ Coverage 45.36% 66.00% +20.63%
===========================================
Files 244 1074 +830
Lines 13333 116417 +103084
Branches 2719 2937 +218
===========================================
+ Hits 6049 76844 +70795
- Misses 6983 35325 +28342
- Partials 301 4248 +3947
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: Martijn Evers <mevers@gk-software.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Changes the
OperationDescriptionfield in audit events to have the redacted payload, rather than the original payload. This makes sure secrets are properly redacted in the visible log entries in the Harbor portal.Issue being fixed
Fixes #22878
Please indicate you've done the following: