Skip to content

encoding/ascii85: fix Decode with exact-size destination buffer#80040

Open
alitavanaei98-droid wants to merge 1 commit into
golang:masterfrom
alitavanaei98-droid:ascii85-decode-short-dst
Open

encoding/ascii85: fix Decode with exact-size destination buffer#80040
alitavanaei98-droid wants to merge 1 commit into
golang:masterfrom
alitavanaei98-droid:ascii85-decode-short-dst

Conversation

@alitavanaei98-droid

Copy link
Copy Markdown

Decode required four spare bytes in dst before processing each input byte, which caused flush of a final short block to fail when dst was sized to the decoded output length. Check available space only when writing output bytes.

Fixes #75590

Change-Id: I1e4794405f4b16126b50891e792ff61a773ca9c9

This PR will be imported into Gerrit with the title and first
comment (this text) used to generate the subject and body of
the Gerrit change.

Please ensure you adhere to every item in this list.

More info can be found at https://go.dev/wiki/CommitMessage

  • The PR title is formatted as follows: net/http: frob the quux before blarfing
    • The package name goes before the colon
    • The part after the colon uses the verb tense + phrase that completes the blank in,
      "This change modifies Go to ___________"
    • Lowercase verb after the colon
    • No trailing period
    • Keep the title as short as possible, ideally 72 characters or shorter
  • No Markdown
  • The first PR comment (this one) is wrapped at around 72 characters, unless it's
    really needed (ASCII art, table, or long link)
  • If there is a corresponding issue, add either Fixes #1234 or Updates #1234
    (the latter if this is not a complete fix) to this comment
  • If referring to a repo other than golang/go you can use the
    owner/repo#issue_number syntax: Fixes golang/vscode-go#1234
  • We do not use Signed-off-by lines in Go. Please don't add them.
    Our Gerrit server & GitHub bots enforce CLA compliance instead.
  • Delete these instructions once you have read and applied them

Decode required four spare bytes in dst before processing each input
byte, which caused flush of a final short block to fail when dst was
sized to the decoded output length. Check available space only when
writing output bytes.

Fixes golang#75590

Change-Id: I1e4794405f4b16126b50891e792ff61a773ca9c9
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: a6e33e5) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/791602.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/791602.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

encoding/ascii85: Decode is wrong when the source is 1 or 5 bytes long

2 participants