Skip to content

regexp: fix latent stale flag bug after NFA prefix fast-forward#80266

Open
le0pard wants to merge 1 commit into
golang:masterfrom
le0pard:lazy-flag-content-in-regex
Open

regexp: fix latent stale flag bug after NFA prefix fast-forward#80266
le0pard wants to merge 1 commit into
golang:masterfrom
le0pard:lazy-flag-content-in-regex

Conversation

@le0pard

@le0pard le0pard commented Jul 5, 2026

Copy link
Copy Markdown

In exec.go, when the NFA machine utilizes m.re.prefix to fast-forward the pos cursor, it updates the runes (r, r1) but fails to recalculate the flag context for the new position. This oversight causes the subsequent m.add() call to evaluate InstEmptyWidth using the stale boundary context from the pre-jump position.

Interestingly, this was implemented correctly in the OnePass engine (doOnePass explicitly calls flag = i.context(pos) after fast-forwarding), but was missed in the NFA match() loop.

Currently, this NFA bug is dormant because syntax.(*Prog).Prefix() halts at InstEmptyWidth, meaning any regex starting with a boundary assertion will have an empty prefix and bypass the fast-forward loop entirely. However, if the prefix extractor is ever optimized to identify literal prefixes after empty-width assertions, this stale flag will immediately cause false positives and negatives.

This commit adds the missing flag = i.context(pos) assignment to the NFA match loop. A test is also included which artificially injects a prefix into a boundary-prefixed Regexp to simulate a smarter compiler and prove the stale flag evaluation.

Found it while was busy with re2js replacing thread pool with a sparse array (because js env have no threads) - le0pard/re2js#48

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 3cdf6af) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/797020.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@le0pard le0pard force-pushed the lazy-flag-content-in-regex branch from 3cdf6af to 77808ec Compare July 5, 2026 14:03
@le0pard le0pard force-pushed the lazy-flag-content-in-regex branch from 77808ec to 37a2398 Compare July 5, 2026 14:07
@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/797020.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/797020.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 37a2398) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/797020.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Jake Bailey:

Patch Set 2: Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/797020.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-07-05T16:21:30Z","revision":"651d35645ed4abc256e55f1437164bbfddc43b45"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/797020.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Jake Bailey:

Patch Set 2: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_3946988>)


Please don’t reply on this GitHub thread. Visit golang.org/cl/797020.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/797020.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/797020.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants