refactor(algorithms): add type hints to cfr.py #1412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks! |
Author
|
Will you merge it....
|
Collaborator
Almost surely, but it has to past tests and be reviewed first. Please also note that we're backlogged (several PRs currently in flight before this one and we're all busy), so there may be a delay. But we tend to merge most things unless there's a serious issue or the quality is too low. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(algorithms): add type hints to cfr.py
Added type hints to the
CFRSolver,_CFRSolverBaseclasses and helper functions.Cleaned up imports and improved docstrings.
Verified by running
cfr_test.py.