Got FFT working again with new syntax.#1347
Got FFT working again with new syntax.#1347duvenaud wants to merge 1 commit intogoogle-research:mainfrom
Conversation
|
Nice!
Sorry about that. Right now I'm trying to simplify the implementation above all else, which means cutting features.
I can explain this one. The new type inference is forward-only and very local (there are arguments for this besides simplifying the implementation but that's another matter). But please keep the friction reports coming regardless. I want to at least be aware of the cost I'm imposing on users with these choices. |
…ements - Add explicit a:Type constraints to odd_sized_palindrome and pad_to_power_of_2 - Add explicit type annotations to butterfly_ixs return values - Add explicit index types to for loops throughout fft.dx - Cast zero to Complex explicitly for pad_to_power_of_2 calls - Use each instead of map in fft-tests.dx - Add index type annotations to 2D FFT functions https://claude.ai/code/session_01N4W4JdwHYfmusD4PuxRqbv
…ements - Add explicit a:Type constraints to odd_sized_palindrome and pad_to_power_of_2 - Add explicit type annotations to butterfly_ixs return values - Add explicit index types to for loops throughout fft.dx - Cast zero to Complex explicitly for pad_to_power_of_2 calls - Use each instead of map in fft-tests.dx - Add index type annotations to 2D FFT functions https://claude.ai/code/session_01N4W4JdwHYfmusD4PuxRqbv
2 participants
I like the new web interface! But it was a little sad adding extra type annotations. I was lucky to realize that an especially hairy type on line 126 could be elided by using
each. But it's not clear to me whyeachis able to infer the type of the index to loop over whenforisn't.