Copybara import of the project: - #11083
Merged
Merged
Conversation
…Xnnpack() axis_info.buffer != nullptr only verifies the Buffer object exists, not that it contains data. A TFLite flatbuffer can declare a constant tensor with a non-null Buffer entry but zero bytes, which is valid per the schema. buffer->Lock().As<const int32_t>() then returns a LockedBufferSpan with a null data pointer (LockedBufferSpan::Empty() in buffer.h:72), and locked_axis.data()[0] dereferences null -> SIGSEGV at model load time. Add the same locked_axis.size() == 0 guard already present in ExpandDimsOperation::ToXnnpack() (lines 1203-1208).
…axis-buffer-null-deref PiperOrigin-RevId: 971606254
copybara-service
Bot
force-pushed
the
test_971404428
branch
from
August 27, 2026 00:49
45e96fd to
073f3b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copybara import of the project:
--
89ef795 by destro4evr-rgb destro4evr@proton.me:
litert/xnnpack: guard against empty axis buffer in SplitOperation::ToXnnpack()
axis_info.buffer != nullptr only verifies the Buffer object exists, not that
it contains data. A TFLite flatbuffer can declare a constant tensor with a
non-null Buffer entry but zero bytes, which is valid per the schema.
buffer->Lock().As() then returns a LockedBufferSpan with a
null data pointer (LockedBufferSpan::Empty() in buffer.h:72), and
locked_axis.data()[0] dereferences null -> SIGSEGV at model load time.
Add the same locked_axis.size() == 0 guard already present in
ExpandDimsOperation::ToXnnpack() (lines 1203-1208).
FUTURE_COPYBARA_INTEGRATE_REVIEW=#11058 from destro4evr-rgb:fix/litert-split-empty-axis-buffer-null-deref 89ef795