make getWorldFromModelMatrix() accessible in fragment shader - #9584
Merged
Conversation
Collaborator
Author
|
@trie94 since this is a new API in materials, is there anything I need to do w.r.t to the new versioning? |
z3moon
approved these changes
Jan 8, 2026
Contributor
yeah add this check in the shader e.g., filament/libs/filamat/tests/test_filamat.cpp Line 1046 in d465d59 btw do we want to use the |
this requires to specify `apiLevel: 2` in the material. FIXES=[474353927]
pixelflinger
force-pushed
the
ma/worldFromModelMatrix
branch
from
January 9, 2026 23:18
e46e79e to
5ffdbe8
Compare
j1george
pushed a commit
to Fieldwire/filament
that referenced
this pull request
Mar 6, 2026
…9584) this requires to specify `apiLevel: 2` in the material. FIXES=[474353927]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIXES=[474353927]