[Python] Inconsistent python generation of union creator types #8843 #8856
Open
jbland64 wants to merge 2 commits intogoogle:masterfrom
Open
[Python] Inconsistent python generation of union creator types #8843 #8856jbland64 wants to merge 2 commits intogoogle:masterfrom
jbland64 wants to merge 2 commits intogoogle:masterfrom
Conversation
github-actions
bot
added
python
c++
codegen
jbland64
changed the title
jbland64
changed the title
jtdavis777
approved these changes
Dec 20, 2025
jtdavis777
added
the
ready-for-merge
aardappel
reviewed
Dec 21, 2025
| test3:Test; | ||
| } | ||
|
|
||
| union Any { Vec3, TestSimpleTableWithEnum } |
Collaborator
There was a problem hiding this comment.
This is going to change this tests generated code for all languages.. lets not do that.
Author
There was a problem hiding this comment.
Ok, what would you suggest as an alternative?
Collaborator
There was a problem hiding this comment.
the least intrusive solution is to create a dedicated test file and case for this
jtdavis777
removed
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8843
tests/nested_union_test.fbs - union name changed to highlight inconsistent union creator naming in generated python code
src/idl_gen_python.cpp - match union creator definition and call
** - other generated files impacted by the above changes