Skip to content

Document tradeoffs between isNotNull() and !!/assertNotNull. #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Sep 16, 2025
+8 −1
Merged

Document tradeoffs between isNotNull() and !!/assertNotNull. #1594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion core/src/main/java/com/google/common/truth/Subject.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,14 @@ public void isNull() {
standardIsEqualTo(null);
}

/** Checks that the value under test is not null. */
/**
* Checks that the value under test is not null.
*
* <p>Kotlin users: A call to {@code assertThat(foo).isNotNull()} does not perform a smart cast on
* {@code foo}. If you require a smart cast, consider using {@code foo!!} or {@code
* assertNotNull(foo)} instead. The tradeoffs are that those will look different than any
* surrounding Truth assertions and that they will produce somewhat worse failure messages.
*/
public void isNotNull() {
standardIsNotEqualTo(null);
}
Expand Down
Loading