Stop explicitly requesting Javadoc and source jars.#1596
Merged
copybara-service[bot] merged 1 commit intomasterfrom Sep 16, 2025
Merged
Stop explicitly requesting Javadoc and source jars.#1596copybara-service[bot] merged 1 commit intomasterfrom
copybara-service[bot] merged 1 commit intomasterfrom
Conversation
Thanks to the configuration changes of cl/805973207, snapshot deployment is [still broken but in a new way](https://github.com/google/truth/actions/runs/17657020721/job/50182316838): ``` [INFO] >>> source:3.3.1:jar (default-cli) > generate-sources @ truth >>> ... [INFO] <<< source:3.3.1:jar (default-cli) < generate-sources @ truth <<< [INFO] [INFO] [INFO] --- source:3.3.1:jar (default-cli) @ truth --- [INFO] Building jar: /home/runner/work/truth/truth/core/target/truth-HEAD-SNAPSHOT-sources.jar ... [INFO] >>> source:3.3.1:jar (attach-sources) > generate-sources @ truth >>> ... [INFO] <<< source:3.3.1:jar (attach-sources) < generate-sources @ truth <<< [INFO] [INFO] [INFO] --- source:3.3.1:jar (attach-sources) @ truth --- [INFO] Building jar: /home/runner/work/truth/truth/core/target/truth-HEAD-SNAPSHOT-sources.jar Error: We have duplicated artifacts attached. ``` The problem is that we're not only requesting Javadoc and source jars explicitly on the command line (which triggers the `default-cli` execution) but also getting them automatically because of the configuration changes of my CL. The solution is to stop requesting them explicitly. That matches [what we do for Guava snapshots](https://github.com/google/guava/blob/087f2c4a8012fb1256f80f6f776df0e8706af683/util/deploy_snapshot.sh#L8). It also matches what we do for non-snapshot releases. RELNOTES=n/a PiperOrigin-RevId: 807772725
copybara-service
bot
force-pushed
the
test_805979172
branch
from
0542447 to
fc57e07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop explicitly requesting Javadoc and source jars.
Thanks to the configuration changes of cl/805973207, snapshot deployment is still broken but in a new way:
The problem is that we're not only requesting Javadoc and source jars explicitly on the command line (which triggers the
default-cliexecution) but also getting them automatically because of the configuration changes of my CL.The solution is to stop requesting them explicitly.
That matches what we do for Guava snapshots. It also matches what we do for non-snapshot releases.
RELNOTES=n/a