Remove unused dependencies on tsl/platform:types#3534
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Remove unused dependencies on tsl/platform:types#3534copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
Bot
force-pushed
the
test_898861870
branch
7 times, most recently
from
46eaa3b to
bec1ee4
Compare
`tsl/platform:types` depends on Eigen and Eigen might depend on CUDA (when built with CUDA support). So each dependency on `tsl/platform:types` might introduce a dependency on CUDA headers which we should avoid. Most dependencies on `tsl/platform:types` are not needed anymore due to the migration to Abseil and `std::string`. They can just be removed. PiperOrigin-RevId: 898861870
copybara-service
Bot
force-pushed
the
test_898861870
branch
from
bec1ee4 to
4d169eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused dependencies on tsl/platform:types
tsl/platform:typesdepends on Eigen and Eigen might depend on CUDA (when built with CUDA support). So each dependency ontsl/platform:typesmight introduce a dependency on CUDA headers which we should avoid.Most dependencies on
tsl/platform:typesare not needed anymore due to the migration to Abseil andstd::string. They can just be removed.