Skip to content

fix(webauthn): format AAGUID as canonical UUID and guard missing clientExtensionResults #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rootkiller6788 wants to merge 3 commits into from
Closed

fix(webauthn): format AAGUID as canonical UUID and guard missing clientExtensionResults #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83e8ff5
fix(webauthn): correct Android app-name regex character class
rootkiller6788 Aug 20, 2026
64bd545
fix(template): correct malformed closing tag for picture-url textfield
rootkiller6788 Aug 20, 2026
aeeaf30
fix(webauthn): format AAGUID as canonical UUID and guard missing clie…
rootkiller6788 Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/webauthn.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export const getOrigin = (
let origin = _origin;
if (!userAgent) return origin;

const appRe = /^[a-zA-z0-9_.]+/;
const appRe = /^[a-zA-Z0-9_.]+/;
const match = userAgent.match(appRe);
if (match) {
// Check if UserAgent comes from a supported Android app.
Expand Down
6 changes: 3 additions & 3 deletions src/public/scripts/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ async function parseAuthData(
// Decode AAGUID
let AAGUID = buffer.slice(0, 16);
AAGUID = Array.from(AAGUID).map(a => (<Number>a).toString(16).padStart(2, '0'));
authData.aaguid = `${AAGUID.splice(0,4).join('')}-${AAGUID.splice(0,2).join('')}-${AAGUID.splice(0,2).join('')}-${AAGUID.splice(0).join('')}`;
authData.aaguid = `${AAGUID.splice(0,4).join('')}-${AAGUID.splice(0,2).join('')}-${AAGUID.splice(0,2).join('')}-${AAGUID.splice(0,2).join('')}-${AAGUID.splice(0).join('')}`;
buffer = buffer.slice(16);

const credIDLenBuf = buffer.slice(0, 2);
Expand Down Expand Up @@ -504,9 +504,9 @@ const listCredentials = async (): Promise<void> => {
<dd>${(new Date(cred.registered)).toLocaleString()}</dd>`:''}
${extensions?.credProps ? html`
<dt>Credential Properties Extension</dt>`:''}
${extensions.credProps?.rk ? html`
${extensions?.credProps?.rk ? html`
<dd>Discoverable Credentials: ${extensions.credProps.rk?'true':'false'}</dd>`:''}
${extensions.credProps?.authenticatorDisplayName ? html`
${extensions?.credProps?.authenticatorDisplayName ? html`
<dd>Authenticator display name: ${extensions.credProps.authenticatorDisplayName}</dd>`:''}
<dt>Public Key</dt>
<dd>${cred.credentialPublicKey}</dd>
Expand Down
2 changes: 1 addition & 1 deletion src/templates/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
type="url"
label="Picture URL"
pattern="^https?:\/\/(?:www\.)?[-a-zA-Z0-9@:%._\+~#=]{1,256}\.?[a-zA-Z0-9()]{1,6}\b(?:[-a-zA-Z0-9()@:%_\+.~#?&\/=]*)$"
id="picture-url"></mwc-textfieldtype=>
id="picture-url"></mwc-textfield>
</div>
<mwc-button
slot="secondaryAction"
Expand Down