fix(PROC-1927): respect compress flag in _handle_new#142
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
compressflag is plumbed fromrunner.py(--compression-mode=PRESERVE→compress=False) throughingest_instances→_handle_new, but was then dropped:_handle_newcalled_compress_instances()unconditionally, making--compression-mode=PRESERVEa no-op. Any caller wanting to skip JPEG2000 encoding (e.g. DICOMs whose pixel data won't encode cleanly) hit compression errors regardless._compress_instances()call in_handle_newon thecompressflag; whenFalse, instances pass through validated-but-untranscoded with no compression errors.test_append_no_compressassertingcompress=Falsepreserves the original transfer syntax and file size.Surfaced while seeding the
gh-laplace-combotest environment, where 16×16 noise frames openjpeg can't encode andPRESERVEfailed to escape compression. A local patch of this shape on Cal's laptop should be reverted once this lands.🤖 Generated with Claude Code