fix #11561: copy button inside context menu#13040
fix #11561: copy button inside context menu#13040KikoMV wants to merge 7 commits intogradio-app:mainfrom
Conversation
bug: when opening the context menu of a cell inside gr.DataFrame the clipboard icon of some component appears above the context menu. fix: created a dedicated container for the DataFrame and changed the stacking priority order.
|
Hi @KikoMV! I'm not sure if this closes the issue - it seems the issue is appearing across multiple components per the issue description: |
Hi! Thank you for the attention, i will look into it. |
|
Hi again @hannahblair, I've ran some tests and it seems like it is working for the different components. My understanding of the bug is that the gr.DataFrame context menu of a cell was appearing behind the copy button of different components. I have tested opening the context menu on top of the different components and it looks fixed. Could you elaborate further on what you meant please? Once again, thank you for the attention. |
🪼 branch checks and previews
|
🦄 change detectedThis Pull Request includes changes to the following packages.
|
|
Hi @KikoMV ! We're in the process of reworking the dataframe entirely (getting rid of dataframe-interim for example) so this change would likely churn |
|
Thanks for opening the PR though |
bug: when opening the context menu of a cell inside gr.DataFrame the clipboard icon of some component appears above the context menu. fix: created a dedicated container for the DataFrame and changed the stacking priority order.
Description
First i tried to individually increase the z-value of the menu, but since it was inside a parent element with a lower stacking context than the copy button, it didnt work. Next i created a dedicated container where i wrapped the DataFrame, then i've made it so that the DataFrame's menu, is in a higher priority order of stack.
Closes: #11561
AI Disclosure
We encourage the use of AI tooling in creating PRs, but the any non-trivial use of AI needs be disclosed. E.g. if you used Claude to write a first draft, you should mention that. Trivial tab-completion doesn't need to be disclosed. You should self-review all PRs, especially if they were generated with AI.
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.shPlease run these bash scripts to automatically format your code:
bash scripts/format_backend.sh, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh