Fix OpenWhisk experiments: update tasks and disable generateProto caching#190
Merged
Fix OpenWhisk experiments: update tasks and disable generateProto caching#190
Conversation
…hing Replace infra-dependent test tasks (testCoverageLean, reportCoverage) with compileScala/compileTestScala to exercise caching without Docker/CouchDB. Add doNotCacheIf hook for GenerateProtoTask — pekko-grpc's logfile_enc option contains an absolute path that breaks cache relocatability in exp3. Upstream: apache/pekko-grpc#661 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ribafish
force-pushed
the
gk/fix-openwhisk-cache-miss
branch
from
8dfe169 to
e60d77e
Compare
ribafish
changed the title
ribafish
added a commit
that referenced
this pull request
Mar 19, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The protobuf plugin class was referenced directly in root build.gradle where it isn't applied, causing Groovy to fail resolving 'com' as a project property. Wrap with pluginManager.withPlugin to defer class resolution, matching the pattern used by the Solr workflow.
…tion on AppliedPlugin delegate
…void classloader issues
Member
Author
There was a problem hiding this comment.
Pull request overview
Updates the Apache OpenWhisk experiment workflow to (1) run Gradle tasks that don’t depend on external infrastructure and (2) work around a cache relocatability issue in generateProto caused by an absolute-path protoc plugin option.
Changes:
- Replace infra-dependent coverage tasks with Scala compilation tasks while keeping Swagger codegen.
- Add a
post-checkoutgit hook to disable caching forgeneratePrototo avoid cache misses across different checkout directories.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
jprinet
approved these changes
Mar 19, 2026
|
|
||
| allprojects { | ||
| tasks.matching { it.name == 'generateProto' }.configureEach { | ||
| outputs.doNotCacheIf('pekko-grpc logfile_enc option is not cache relocatable') { true } |
Member
There was a problem hiding this comment.
just nitpicking but your upstream PR link could be part of the not cacheable reason
Updated the disable caching script for generateProto to include a link to the related pull request. Signed-off-by: Gašper Kojek <gkojek@gradle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for Apache OpenWhisk experiment workflows:
Replace infra-dependent tasks —
testCoverageLean(160/163 suites fail without Docker/CouchDB/Ansible) andreportCoverage(needs Ansible-generatedwhisk.properties) replaced withcompileScalaandcompileTestScalato exercise dependency resolution and Scala compilation caching.testSwaggerCodegen(pure codegen, no infra) kept.Disable caching for
GenerateProtoTask— The pekko-grpc Gradle plugin passes an absolute path (logfile_enc) as a protoc plugin option, which protobuf-gradle-plugin registers as a task input. This breaks cache relocatability in experiment 3 (same commit, different checkout directories). Added adoNotCacheIfpost-checkout hook.Upstream issue
apache/pekko-grpc#661
Test plan