Skip to content

fix(distributor): Add partition labels to Kafka write bytes metric #23309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hundredwatt wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(distributor): Add partition labels to Kafka write bytes metric #23309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/distributor/distributor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1570,12 +1570,12 @@
// TODO(grobinson): We should emit the write latency even when we failed.
// This has been kept as-is for now to preserve behavior.
writeLatency.ObserveDuration()
d.m.kafkaWriteBytesTotal.Add(float64(sizeBytes))
d.m.kafkaWriteBytesTotal.WithLabelValues(fmt.Sprintf("partition_%d", result.Record.Partition).Add(float64(sizeBytes))

Check failure on line 1573 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / Test Build loki (linux/amd64) 

syntax error: unexpected newline in argument list; possibly missing comma or )

Check failure on line 1573 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / Test Build querytee (linux/arm64) 

syntax error: unexpected newline in argument list; possibly missing comma or )

Check failure on line 1573 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / Test Build querytee (linux/amd64) 

syntax error: unexpected newline in argument list; possibly missing comma or )

Check failure on line 1573 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / Test Build querytee (linux/arm) 

syntax error: unexpected newline in argument list; possibly missing comma or )

Check failure on line 1573 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / Test Build loki (linux/arm) 

syntax error: unexpected newline in argument list; possibly missing comma or )

Check failure on line 1573 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / Test Build logcli (linux/arm64) 

syntax error: unexpected newline in argument list; possibly missing comma or )

Check failure on line 1573 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / Test Build loki (linux/arm64) 

syntax error: unexpected newline in argument list; possibly missing comma or )

Check failure on line 1573 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / Test Build logcli (linux/arm) 

syntax error: unexpected newline in argument list; possibly missing comma or )

Check failure on line 1573 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / Test Build logcli (linux/amd64) 

syntax error: unexpected newline in argument list; possibly missing comma or )

Check failure on line 1573 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / govulncheck 

missing ',' before newline in argument list

Check failure on line 1573 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / Test Build logcli (linux/arm64) 

syntax error: unexpected newline in argument list; possibly missing comma or )

Check failure on line 1573 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / Test Build logcli (linux/arm) 

syntax error: unexpected newline in argument list; possibly missing comma or )

Check failure on line 1573 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / Test Build loki (linux/arm) 

syntax error: unexpected newline in argument list; possibly missing comma or )

Check failure on line 1573 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / Test Build querytee (linux/arm) 

syntax error: unexpected newline in argument list; possibly missing comma or )

Check failure on line 1573 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / Test Build querytee (linux/amd64) 

syntax error: unexpected newline in argument list; possibly missing comma or )

Check failure on line 1573 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / Test Build loki (linux/arm64) 

syntax error: unexpected newline in argument list; possibly missing comma or )

Check failure on line 1573 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / Test Build logcli (linux/amd64) 

syntax error: unexpected newline in argument list; possibly missing comma or )

Check failure on line 1573 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / Test Build loki (linux/amd64) 

syntax error: unexpected newline in argument list; possibly missing comma or )

Check failure on line 1573 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / Test Build querytee (linux/arm64) 

syntax error: unexpected newline in argument list; possibly missing comma or )

Check failure on line 1573 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / govulncheck 

missing ',' before newline in argument list
}

Check failure on line 1574 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / govulncheck 

expected operand, found '}'

Check failure on line 1574 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / govulncheck 

expected operand, found '}'
var finalErr error

Check failure on line 1575 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / govulncheck 

expected operand, found newline

Check failure on line 1575 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / govulncheck 

missing ',' in argument list

Check failure on line 1575 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / govulncheck 

missing ',' in argument list

Check failure on line 1575 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / govulncheck 

expected operand, found newline

Check failure on line 1575 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / govulncheck 

missing ',' in argument list

Check failure on line 1575 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / govulncheck 

missing ',' in argument list
for _, result := range results {

Check failure on line 1576 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / govulncheck 

expected operand, found 'range'

Check failure on line 1576 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / govulncheck 

missing ',' in argument list

Check failure on line 1576 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / govulncheck 

missing ',' in argument list

Check failure on line 1576 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / govulncheck 

expected operand, found 'range'

Check failure on line 1576 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / govulncheck 

missing ',' in argument list

Check failure on line 1576 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / govulncheck 

missing ',' in argument list
if result.Err != nil {

Check failure on line 1577 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / govulncheck 

missing ',' in argument list

Check failure on line 1577 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / govulncheck 

missing ',' in argument list
d.m.kafkaAppends.WithLabelValues(fmt.Sprintf("partition_%d", result.Record.Partition), "fail").Inc()

Check failure on line 1578 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / govulncheck 

missing ',' before newline in composite literal

Check failure on line 1578 in pkg/distributor/distributor.go

View workflow job for this annotation

GitHub Actions / govulncheck 

missing ',' before newline in composite literal
finalErr = result.Err
} else {
d.m.kafkaAppends.WithLabelValues(fmt.Sprintf("partition_%d", result.Record.Partition), "success").Inc()
Expand Down
Loading