Skip to content

return error at startup when no write path is configured#6630

Open
areebahmeddd wants to merge 4 commits intografana:mainfrom
areebahmeddd:fix/distributor-no-write-path-error
Open

return error at startup when no write path is configured#6630
areebahmeddd wants to merge 4 commits intografana:mainfrom
areebahmeddd:fix/distributor-no-write-path-error

Conversation

@areebahmeddd
Copy link

What this PR does:

  • IngesterWritePathEnabled is hardcoded to false, and KafkaWritePathEnabled is set to ingest.Enabled (which defaults to false).
  • With both flags off, the distributor starts without errors but silently drops all traces.
  • This PR adds a check in Config.Validate() to throw a clear error if both write paths are disabled, so Tempo fails at startup with a useful error message.

Which issue(s) this PR fixes:

Fixes #6629

Checklist:

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@cla-assistant
Copy link

cla-assistant bot commented Mar 9, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@areebahmeddd areebahmeddd force-pushed the fix/distributor-no-write-path-error branch from 518e9fa to 7c86b72 Compare March 9, 2026 04:35
@mdisibio
Copy link
Contributor

mdisibio commented Mar 9, 2026

Hi thank you for the fix.

@mapno @javiermolinar - Is this related to additional 3.0 cleanup needed? For example I'm thinking in 3.0 the distributor shouldn't be able to enter into this situation, it would always require the Kafka write-path to be enabled. But I remember we were considering a non-kafka solution for single binary.

@areebahmeddd
Copy link
Author

I'm thinking in 3.0 the distributor shouldn't be able to enter into this situation, it would always require the Kafka write-path to be enabled.

yea i figured the same.

But I remember we were considering a non-kafka solution for single binary.

made a small change to the pr; switched the test target to fix the failing check. i randomly spent some time tracing this one down so hoping this gets merged 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

distributor silently drops all traces when no write path is configured

2 participants