return error at startup when no write path is configured#6630
return error at startup when no write path is configured#6630areebahmeddd wants to merge 4 commits intografana:mainfrom
Conversation
|
|
518e9fa to
7c86b72
Compare
|
Hi thank you for the fix. @mapno @javiermolinar - Is this related to additional 3.0 cleanup needed? For example I'm thinking in 3.0 the distributor shouldn't be able to enter into this situation, it would always require the Kafka write-path to be enabled. But I remember we were considering a non-kafka solution for single binary. |
yea i figured the same.
made a small change to the pr; switched the test target to fix the failing check. i randomly spent some time tracing this one down so hoping this gets merged 🙂 |
What this PR does:
IngesterWritePathEnabledis hardcoded tofalse, andKafkaWritePathEnabledis set toingest.Enabled(which defaults tofalse).Config.Validate()to throw a clear error if both write paths are disabled, so Tempo fails at startup with a useful error message.Which issue(s) this PR fixes:
Fixes #6629
Checklist:
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]