[jsonnet]: set block-builder to follow repliacs of live-store by default#6634
Merged
zalegrala merged 1 commit intografana:mainfrom Mar 10, 2026
Conversation
zalegrala
changed the title
zalegrala
requested review from
carles-grafana,
electron0zero,
ie-pham,
javiermolinar,
mapno,
mattdurham,
mdisibio,
oleg-kozlyuk-grafana,
ruslan-mikhailov,
stoewer and
yvrhdn
as code owners
Contributor
|
When scaling down a cluster - the rollout operator already drains a live store and waits 30-60 minutes for it to go outside the query window, before actually removing the pod, correct? I think that gives enough time for the block builder to drain and flush it's partition as well. |
Contributor
Author
|
Yes, that's correct, which is why we are using the live-store statefulset here (we picked |
javiermolinar
approved these changes
Mar 10, 2026
zalegrala
deleted the
tempoMicroservicesBlockBuilderFollowLiveStoreReplicas
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Here we set the rollout-operator to manage the replicas of the block-builder and follow the live-store, since the replicas should always match. Rollout-operator is no longer optional for live-store, and so we continue to leverage it here for this purpose.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]