feat(compiler): Introduce warning if non-void expression value not used or ignored - #2141
Open
alex-snezhko wants to merge 2 commits into
Open
feat(compiler): Introduce warning if non-void expression value not used or ignored#2141alex-snezhko wants to merge 2 commits into
alex-snezhko wants to merge 2 commits into
Conversation
alex-snezhko
requested review from
jozanza,
marcusroberts,
ospencer,
peblair and
phated
as code owners
August 14, 2024 05:04
Member
|
Let's land this in the next breaking so users aren't surprised by the warnings. |
ospencer
approved these changes
Sep 22, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 22, 2024
Member
|
@alex-snezhko can you rebase this? Looks like the tests are failing on merge because of the LSP tests. |
alex-snezhko
force-pushed
the
alex/non-void-expr-warning
branch
from
September 22, 2024 20:36
d6a6fd5 to
dff6f7b
Compare
Member
Author
|
@ospencer rebased and fixed tests |
ospencer
approved these changes
Sep 22, 2024
Member
|
@alex-snezhko looks like tests are failing because of formatting. |
alex-snezhko
force-pushed
the
alex/non-void-expr-warning
branch
from
September 22, 2024 21:17
dff6f7b to
b55bd41
Compare
marcusroberts
approved these changes
Oct 10, 2024
marcusroberts
left a comment
Member
There was a problem hiding this comment.
Nice improvement, I like getting these warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The below code will now give a warning