Manage image centers different from (w/2,h/2)#42
Open
ookey wants to merge 2 commits intographdeco-inria:mainfrom
Open
Manage image centers different from (w/2,h/2)#42ookey wants to merge 2 commits intographdeco-inria:mainfrom
ookey wants to merge 2 commits intographdeco-inria:mainfrom
Conversation
…nsform full_projection_transform is the multiplication of view_matrix and projection_matrix. Thus, passing (view_matrix, projection_matrix) is equivalent to (view_matrix, full_projection_transform). Passing projection_matrix as arguments to rasterize_gaussians enables to get intrinsics informations in the rendering code. Since we'll need central point (cx, cy), this is the aim of this refacto commit. Signed-off-by: Matthieu Gendrin <matthieu.gendrin@orange.com>
Some data have image centers different from (w/2,h/2). This can be after a correction of distortion, or because some images are cropped. To manage this case, we pass projmatrix to the rendering classes, which include cx,cy information (on top of fx, fy). Signed-off-by: Matthieu Gendrin <matthieu.gendrin@orange.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some data have image centers different from (w/2,h/2). This can be after a correction of distortion, or because some images are cropped.
To manage this case, we pass projmatrix to the rendering classes, which include cx,cy information (on top of fx, fy).
Note that this evolution changes the signature of the module:
CudaRasterizer::Rasterizer::forwardprojmatrix parameter is now the plain projection_matrix (whereas it used to be the full_projection_matrix), and tan_fovx and tan_fovy are not needed anymore.This merge request has to be synchronized with mge/zoom on gaussian-splatting repo. See that MR for testing procedure.