Skip to content

Converter extractor changes#795

Merged
Aske-Rosted merged 3 commits intographnet-team:mainfrom
Aske-Rosted:converter_extractor_changes
May 9, 2025
Merged

Converter extractor changes#795
Aske-Rosted merged 3 commits intographnet-team:mainfrom
Aske-Rosted:converter_extractor_changes

Conversation

@Aske-Rosted
Copy link
Copy Markdown
Collaborator

@Aske-Rosted Aske-Rosted commented Apr 22, 2025

changes to the converter and extractor modules.

  • Adds option to change the output dir of the merger
  • Properly set the gcd file in the CombinedExtractor
  • Adds option to exclude some of the values extracted by the extractor.

Part of the partioning of #789.

def __init_subclass__(cls) -> None:
"""Initialize subclass and apply the exclude decorator to __call__."""
super().__init_subclass__()
cls.__call__ = cls.exclude(cls.__call__) # type: ignore
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a pretty elegant solution!

Copy link
Copy Markdown
Collaborator

@RasmusOrsoe RasmusOrsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Aske-Rosted Aske-Rosted merged commit 4bee06e into graphnet-team:main May 9, 2025
13 of 14 checks passed
@Aske-Rosted Aske-Rosted deleted the converter_extractor_changes branch May 9, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants