polish: unify our formatted and non-formatted execution result types - #4504
Closed
yaacovCR wants to merge 5 commits into
Closed
polish: unify our formatted and non-formatted execution result types#4504yaacovCR wants to merge 5 commits into
yaacovCR wants to merge 5 commits into
Conversation
via using a new generic type parameter with this pattern:
export interface ExecutionResult<
TData = ObjMap<unknown>,
TExtensions = ObjMap<unknown>,
TError extends GraphQLError | GraphQLFormattedError = GraphQLError,
> {
errors?: ReadonlyArray<TError>;
data?: TData | null;
extensions?: TExtensions;
}
export interface FormattedExecutionResult<
TData = ObjMap<unknown>,
TExtensions = ObjMap<unknown>,
> extends ExecutionResult<TData, TExtensions, GraphQLFormattedError> {}
This should remove maintenance burden, as we explicitly say that the formatted types only differ from the unformatted in that they have a formatted error type.
yaacovCR
added
the
PR: polish 💅
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Feb 15, 2026
at @IvanGoncharov's suggestions => allows GraphQLError class to implement GraphQLFormattedError interface alternative to parts of graphql#4504
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
via using a new generic type parameter with this pattern:
This should remove maintenance burden, as we explicitly say that the formatted types only differ from the unformatted in that they have a formatted error type.
See:
#4481
#4333