Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
martinbonnin
left a comment
martinbonnin
left a comment
There was a problem hiding this comment.
Thanks for looking into this! Few comments below
martinbonnin
changed the title
martinbonnin
changed the title
…text on extending interfaces
mjmahone
left a comment
mjmahone
left a comment
There was a problem hiding this comment.
So the biggest thing I'd say is that we should be explicit that we're making extend mean merge: at each level it's OK for something to be missing in the extend, in which case that means we use the original value if any, but if it exists on both it must be exactly matching.
| ``` | ||
|
|
||
| ```graphql example | ||
| extend type Query { |
There was a problem hiding this comment.
in this world, extend is a keyword for merge?
| two fields may share the same name. | ||
| 2. If a field with the same name exists on the previous Object type: | ||
| 1. The field type must match the previous definition exactly. | ||
| 2. The field description must match the previous definition exactly. |
There was a problem hiding this comment.
or be empty. It would be really annoying to not be able to extend a field because I chose not to add the description.
There was a problem hiding this comment.
Agree this should be the intended outcome.
5 participants
Uh oh!
There was an error while loading. Please reload this page.