Return exit code 0 after displaying help text with -h - #429
Merged
Conversation
Member
|
You're right, that was bothering me too. I've tweaked it a bit, so now there aren't any error messages in parallel mode either. I've probably just introduced a new bug... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling the application with
-hto display the help text the return code wasEXIT_FAILURE, even though this the intended use case and no error has occurred. The return code for this particular case is now changed toEXIT_SUCCESS.It is not a big deal, but confused me a little when I was using
groops -hfor testing where I needed the application to do nothing else but terminate itself successfully.