support: Enabling API token header "X-GROWI-ACCESS-TOKEN"#10443
Open
ryu-sato wants to merge 12 commits intogrowilabs:masterfrom
Open
support: Enabling API token header "X-GROWI-ACCESS-TOKEN"#10443ryu-sato wants to merge 12 commits intogrowilabs:masterfrom
ryu-sato wants to merge 12 commits intogrowilabs:masterfrom
Conversation
…GROWI-ACCESS-TOKEN header
ryu-sato
requested review from
Copilot,
miya and
yuki-takei
and removed request for
Copilot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request proposes enabling the use of X-GROWI-ACCESS-TOKEN as a method for obtaining API tokens.
Currently, GROWI allows you to set the access_token either as a Bearer token in the Authorization header or as an access_token query parameter.
ref. https://docs.growi.org/en/api/rest-v3.html
If the Authorization header is already in use (e.g., for Basic authentication), you need to use the query parameter.
However, sending the token via a GET method query parameter is not secure as it requires including the token in the URL.
see. https://owasp.org/www-community/vulnerabilities/Information_exposure_through_query_strings_in_url