-
Notifications
You must be signed in to change notification settings - Fork 4k
Add new classes for eliminating xds config tears #11740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
fd069e3
Framework definition to support A74
larry-safran b2cb05b
Test that update works (with associated fixes)
larry-safran 8e668b5
Cleanup
larry-safran 5b14a3e
Cleanup
larry-safran 5f8d479
Add verification of data changing
larry-safran ec50490
Support aggregate clusters correctly
larry-safran 5dceeaf
Fix class name referenced in javadoc
larry-safran fd64f20
Address a number of code review comments and add a test for missing C…
larry-safran b2e924e
Remove syncContext from watchers. Add checkNotNull, private and fina…
larry-safran 5a75b10
Add a test for corrupt LDS
larry-safran d3b713f
Change aggregate cluster handling to correctly handle cluster names a…
larry-safran 6089730
Errorprone
larry-safran d5dea83
Add max recursion limit for clusters to match c++.
larry-safran 28d29fb
Fix handling of route and cluster updates.
larry-safran 4a53fce
Make data private and XdsWatcherBase static
larry-safran c97118f
In LDS onChanged(), get old activeVirtualHost before possibly doing c…
larry-safran 06466fc
Change comment for clarity
larry-safran b898e34
Allow EdsWatcher to have multiple CdsWatcher parents
larry-safran 954ced3
Allow EdsWatcher to have multiple CdsWatcher parents
larry-safran ef13712
Fully support inlined RouteConfig
larry-safran 518cef1
Add lots of `checkNotNull()`
larry-safran 68071e6
Add test case testMultipleParentsInCdsTree, make a couple of cluster …
larry-safran f99fc56
Add test case testMultipleParentsInCdsTree, make a couple of cluster …
larry-safran 482cd9d
Add virtual host to XdsConfig as per spec
larry-safran 36602b6
Eliminate clusterSubscriptions and use objects directly instead of st…
larry-safran 7042ed9
Add tests. Fix some places that were still using string instead of o…
larry-safran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,192 @@ | ||
| /* | ||
| * Copyright 2024 The gRPC Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package io.grpc.xds; | ||
|
|
||
| import static com.google.common.base.Preconditions.checkNotNull; | ||
|
|
||
| import com.google.common.collect.ImmutableMap; | ||
| import io.grpc.StatusOr; | ||
| import io.grpc.xds.XdsClusterResource.CdsUpdate; | ||
| import io.grpc.xds.XdsEndpointResource.EdsUpdate; | ||
| import io.grpc.xds.XdsListenerResource.LdsUpdate; | ||
| import io.grpc.xds.XdsRouteConfigureResource.RdsUpdate; | ||
| import java.io.Closeable; | ||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import java.util.Objects; | ||
|
|
||
| /** | ||
| * Represents the xDS configuration tree for a specified Listener. | ||
| */ | ||
| final class XdsConfig { | ||
| private final LdsUpdate listener; | ||
| private final RdsUpdate route; | ||
| private final VirtualHost virtualHost; | ||
| private final ImmutableMap<String, StatusOr<XdsClusterConfig>> clusters; | ||
| private final int hashCode; | ||
|
|
||
| XdsConfig(LdsUpdate listener, RdsUpdate route, Map<String, StatusOr<XdsClusterConfig>> clusters, | ||
| VirtualHost virtualHost) { | ||
| this(listener, route, virtualHost, ImmutableMap.copyOf(clusters)); | ||
| } | ||
|
|
||
| public XdsConfig(LdsUpdate listener, RdsUpdate route, VirtualHost virtualHost, | ||
| ImmutableMap<String, StatusOr<XdsClusterConfig>> clusters) { | ||
| this.listener = listener; | ||
| this.route = route; | ||
| this.virtualHost = virtualHost; | ||
| this.clusters = clusters; | ||
|
|
||
| hashCode = Objects.hash(listener, route, virtualHost, clusters); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object obj) { | ||
| if (!(obj instanceof XdsConfig)) { | ||
| return false; | ||
| } | ||
|
|
||
| XdsConfig o = (XdsConfig) obj; | ||
|
|
||
| return hashCode() == o.hashCode() && Objects.equals(listener, o.listener) | ||
| && Objects.equals(route, o.route) && Objects.equals(virtualHost, o.virtualHost) | ||
| && Objects.equals(clusters, o.clusters); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return hashCode; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| StringBuilder builder = new StringBuilder(); | ||
| builder.append("XdsConfig{") | ||
| .append("\n listener=").append(listener) | ||
| .append(",\n route=").append(route) | ||
| .append(",\n virtualHost=").append(virtualHost) | ||
| .append(",\n clusters=").append(clusters) | ||
| .append("\n}"); | ||
| return builder.toString(); | ||
| } | ||
|
|
||
| public LdsUpdate getListener() { | ||
| return listener; | ||
| } | ||
|
|
||
| public RdsUpdate getRoute() { | ||
| return route; | ||
| } | ||
|
|
||
| public VirtualHost getVirtualHost() { | ||
| return virtualHost; | ||
| } | ||
|
|
||
| public ImmutableMap<String, StatusOr<XdsClusterConfig>> getClusters() { | ||
| return clusters; | ||
| } | ||
|
|
||
| static final class XdsClusterConfig { | ||
| private final String clusterName; | ||
| private final CdsUpdate clusterResource; | ||
| private final StatusOr<EdsUpdate> endpoint; //Will be null for non-EDS clusters | ||
|
|
||
| XdsClusterConfig(String clusterName, CdsUpdate clusterResource, | ||
| StatusOr<EdsUpdate> endpoint) { | ||
| this.clusterName = checkNotNull(clusterName, "clusterName"); | ||
| this.clusterResource = checkNotNull(clusterResource, "clusterResource"); | ||
| this.endpoint = endpoint; | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| int endpointHash = (endpoint != null) ? endpoint.hashCode() : 0; | ||
| return clusterName.hashCode() + clusterResource.hashCode() + endpointHash; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object obj) { | ||
| if (!(obj instanceof XdsClusterConfig)) { | ||
| return false; | ||
| } | ||
| XdsClusterConfig o = (XdsClusterConfig) obj; | ||
| return Objects.equals(clusterName, o.clusterName) | ||
| && Objects.equals(clusterResource, o.clusterResource) | ||
| && Objects.equals(endpoint, o.endpoint); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| StringBuilder builder = new StringBuilder(); | ||
| builder.append("XdsClusterConfig{clusterName=").append(clusterName) | ||
| .append(", clusterResource=").append(clusterResource) | ||
| .append(", endpoint=").append(endpoint).append("}"); | ||
| return builder.toString(); | ||
| } | ||
|
|
||
| public String getClusterName() { | ||
ejona86 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| return clusterName; | ||
| } | ||
|
|
||
| public CdsUpdate getClusterResource() { | ||
| return clusterResource; | ||
| } | ||
|
|
||
| public StatusOr<EdsUpdate> getEndpoint() { | ||
| return endpoint; | ||
| } | ||
| } | ||
|
|
||
| static final class XdsConfigBuilder { | ||
| private LdsUpdate listener; | ||
| private RdsUpdate route; | ||
| private Map<String, StatusOr<XdsClusterConfig>> clusters = new HashMap<>(); | ||
| private VirtualHost virtualHost; | ||
|
|
||
| XdsConfigBuilder setListener(LdsUpdate listener) { | ||
| this.listener = checkNotNull(listener, "listener"); | ||
| return this; | ||
| } | ||
|
|
||
| XdsConfigBuilder setRoute(RdsUpdate route) { | ||
| this.route = checkNotNull(route, "route"); | ||
| return this; | ||
| } | ||
|
|
||
| XdsConfigBuilder addCluster(String name, StatusOr<XdsClusterConfig> clusterConfig) { | ||
ejona86 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| checkNotNull(name, "name"); | ||
| checkNotNull(clusterConfig, "clusterConfig"); | ||
| clusters.put(name, clusterConfig); | ||
| return this; | ||
| } | ||
|
|
||
| XdsConfigBuilder setVirtualHost(VirtualHost virtualHost) { | ||
| this.virtualHost = checkNotNull(virtualHost, "virtualHost"); | ||
| return this; | ||
| } | ||
|
|
||
| XdsConfig build() { | ||
| checkNotNull(listener, "listener"); | ||
| checkNotNull(route, "route"); | ||
| return new XdsConfig(listener, route, clusters, virtualHost); | ||
| } | ||
| } | ||
|
|
||
| public interface XdsClusterSubscriptionRegistry { | ||
| Closeable subscribeToCluster(String clusterName); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.