Conversation
glbrntt
force-pushed
the
more-tracing-tests
branch
from
3ed6e66 to
adaedbd
Compare
glbrntt
force-pushed
the
more-tracing-tests
branch
from
54dd1ce to
ec49497
Compare
gjcairo
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The OTel tracing interceptors have a few shortcomings
which need fixing. This includes ending the span too
early. This change introduces a number of new tests
which test client and server end-to-end. These tests
currently fail because of the aforementioned issues so
are disabled.
Modifications:
Result:
Better test coverage