Skip to content

fix(calculations): Fix PSI based balancing which resulted in a Python KeyError #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gyptazy merged 1 commit into from
Jan 13, 2026
+4 −1
Merged

fix(calculations): Fix PSI based balancing which resulted in a Python KeyError #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changelogs/1.1.12/420_fix_psi_based_balancing_key_error.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fixed:
- Fix PSI based balancing which resulted in a Python KeyError (@gyptazy). [#420]
3 changes: 2 additions & 1 deletion proxlb/models/calculations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,11 +418,12 @@ def relocate_guests(proxlb_data: Dict[str, Any]):
break

for guest_name in proxlb_data["groups"]["affinity"][group_name]["guests"]:

# Stop moving guests if the source node is no longer the most loaded
source_node = proxlb_data["guests"][guest_name]["node_current"]
method = proxlb_data["meta"]["balancing"].get("method", "memory")
mode = proxlb_data["meta"]["balancing"].get("mode", "used")
highest_node = max(proxlb_data["nodes"].values(), key=lambda n: n[f"{method}_{mode}_percent"])
highest_node = max(proxlb_data["nodes"].values(), key=lambda n: n[f"{method}_used_percent"])

if highest_node["name"] != source_node:
logger.debug(f"Stopping relocation for guest {guest_name}: source node {source_node} is no longer the most loaded node.")
Expand Down