Add setting to choose how to open office documents - #1149
Open
commandervoid wants to merge 2 commits into
Open
Conversation
Contributor
|
Thank you for your PR, this is a very useful feature |
Author
|
One thing I didn't do yet is set the app picker to have the 'Always open' option when the EXTERNAL option is selected. I'm planning to do that in a followup PR (or you can just change that here if you'd like). |
Contributor
|
Since the app already includes the ability to open Office-type files, and adding this feature would require additional configuration options, this PR will be put on hold for now. For now, can open documents using the local app by following these steps: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add setting to choose how office documents (docx, xlsx, pptx,
etc.) are opened: Seafile's internal webview (default), in an external app,
or to be asked each time. Also carved out cache checking functionality
to avoid code duplication and fixed up an old test.
Changes
User-facing
"Open in Seafile", "Open in external app", "Ask each time"
with user intent to pick an external app)
Testing
Utils.getOfficeFileClickAction()covering all code paths(no OnlyOffice server support, non-office file, INTERNAL/EXTERNAL/ASK)
FileCacheHelper.checkRemoteAndOpen()coveringnot cached, a stale cache, and an up-to-date cache.
StringNaturalOrderComparator.