Fix broken links in Chapter 17, plus consistency changes#241
Closed
defndaines wants to merge 283 commits intohappi:masterfrom
Closed
Fix broken links in Chapter 17, plus consistency changes#241defndaines wants to merge 283 commits intohappi:masterfrom
defndaines wants to merge 283 commits intohappi:masterfrom
Conversation
This is still WIP, but added/update new installation info about asciidoctor.
- for pdf, ./images - for html, ./site/images
- Update README for the list of install/requirements - Update Makefile to build beam-book.pdf using new build tools
- Removed "scale" option of diita - Adjusted the diagrams so that it looks better when there are multiple boxes - Fix equal sign rendered by diita, by using arrow symbol instead of equal sign
- Port communication diagram - Entities on Erlang Node diagram
It makes link macros not working.
So that changes to chapter files are detected.
Adjust align of boxes and show legend to upper right corner.
- Stack and heap are in same memory area - Improve minor alignments of diagrams
Followed the in struction here: https://help.github.com/en/github/using-git/configuring-git-to-handle-line-endings
ditaa does not handle diagonal lines and this diagram is better off as it is.
Add missed colon
Change xrefstyle to short Reference: https://github.com/asciidoctor/asciidoctor.org/blob/master/docs/_includes/xrefstyle.adoc After some discussion and looking at several technical books, this seems to be the popular style, and picking this one for now.
- Use graphviz for Erlang type lattice diagram - Add a link to erl_term.h - Slightly better look for tag scheme diagram - Other minor adjustments
* Add bibliography ref to WAM * Add links to code/modules * Format: use monospace for code related parts
Add missing comas to improve text readability
Reductions are covered earlier in the chapter, it seems this section got duplicated somehow.
... for asciidoctor-pdf (docker image)
Replace if by is
Fix small grammar issues, including a few comma splices.
It’s the only chapter that’s prefixed with “Chapter: ”. Also addressing a couple capitalization issues.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Computes version as 1.0.N where N is the commit count since the v1.0 tag. Passed as an AsciiDoc attribute to all build targets (PDF, EPUB, HTML). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
In section 7.5.2, the prose said "end up at L3" for loop_rec_end and "wait instruction at L4", but loop_rec_end is at L2 and wait is at L3. Also fixed "jumps back to L2" to "jumps back to L1". Fixes happi#234 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Type chunk (OTP 25+) holds JIT type info as fixed 16-byte records prefixed by a version and count field. The book incorrectly showed binary_to_term which fails at runtime. Updated the binary format description and parsing code to match beamfile.erl. Fixes happi#227 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The emoji characters (U+1F60E) rendered as empty squares in the PDF because they are outside the Noto Serif font coverage. Replaced with Greek letters lambda, pi, sigma (955, 960, 963) which Noto Serif supports and which still demonstrate the +pc unicode shell behavior. Fixes happi#211 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Ignore VERSION, cover image, vendor bundle, and Gemfile.lock used by the local publish pipeline on the build server. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove .mcp.json and backlog/ from tracking. These are local development workflow files that should not be in the public repo. Add them to .gitignore alongside CLAUDE.local.md. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fixes happi#240 — the [xxx](#ch.live) link pointed to a chapter that was never included in the build.
Owner
|
Thank you for fixing the broken links and consistency issues in the ops chapter, Michael! Really appreciate it. I've cherry-picked your changes into master (commit d9dbd87). Apologies for the messy diff — a recent force-push rewrote the history and made this PR show a much larger diff than it should. Your actual changes are now merged. Closing this PR. Thanks again for all your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the chapter and external links are fixed here.