feat: [DBOPS-1363]: Onboarding two new static steps LiquibaseUpdateSQLStep & LiquibaseRollbackSQLStep#627
feat: [DBOPS-1363]: Onboarding two new static steps LiquibaseUpdateSQLStep & LiquibaseRollbackSQLStep#627bikramHarness wants to merge 1 commit intomainfrom
Conversation
bikramHarness
requested review from
abhinavmittal-harness,
abhinavsingh1196,
abosii-harness,
anilchowdhury-harness,
archit-harness,
deepharness,
dgarg-harness,
harshjain12,
hemanthmantri,
ivan-83,
nassergonzalez,
puthrayaharness,
rohitk-h,
utkarshchoubey-harness,
vikyathharekal,
vlica-harness and
yogesh-chauhan
as code owners
|
|
bikramHarness
force-pushed
the
dbops-1363
branch
from
f82b305 to
2b73859
Compare
v0/pipeline/steps/common/dbops-liquibase-rollback-sql-step-node.yaml
Outdated
Show resolved
Hide resolved
v0/pipeline/steps/common/dbops-liquibase-update-sql-step-info.yaml
Outdated
Show resolved
Hide resolved
| type: string | ||
| command: | ||
| type: string | ||
| settings: |
There was a problem hiding this comment.
why only its present in update-sql and not rollback-sql
There was a problem hiding this comment.
plus i think it should be globalSettings as per current field
There was a problem hiding this comment.
Same, copied from existing step
v0/pipeline/steps/common/dbops-liquibase-update-sql-step-info.yaml
Outdated
Show resolved
Hide resolved
| properties: | ||
| dbInstance: | ||
| type: string | ||
| dbSchema: | ||
| type: string | ||
| connectorRef: | ||
| type: string | ||
| settings: | ||
| oneOf: | ||
| - $ref: ../../common/parameter-field-map-string-json-node.yaml | ||
| - type: string | ||
| command: | ||
| type: string | ||
| delegateSelectors: | ||
| oneOf: | ||
| - type: array | ||
| items: | ||
| type: string | ||
| - type: string |
There was a problem hiding this comment.
why its getting repeated again properties?
There was a problem hiding this comment.
Took this from the existing LiquibaseCustomCommand,
should we remove this
| - $ref: ../../steps/common/dbops-liquibase-command-step-node.yaml | ||
| - $ref: ../../steps/common/files-upload-step-node.yaml | ||
| - $ref: ../../steps/custom/event-listener-step-node.yaml | ||
| - $ref: ../../steps/common/dbops-liquibase-update-sql-step-node.yaml |
There was a problem hiding this comment.
update not to have liquibase
bikramHarness
force-pushed
the
dbops-1363
branch
from
9b3d94d to
e68edbb
Compare
| - $ref: ../../steps/common/dbops-liquibase-command-step-node.yaml | ||
| - $ref: ../../steps/common/files-upload-step-node.yaml | ||
| - $ref: ../../steps/custom/event-listener-step-node.yaml | ||
| - $ref: ../../steps/common/db-schema-update-sql-step-node.yaml |
There was a problem hiding this comment.
i dont think we need to support here, only cd and custom should be fine
There was a problem hiding this comment.
removed from approval stage
bot2-harness
force-pushed
the
dbops-1363
branch
from
62b845c to
798d5ca
Compare
…LStep & LiquibaseRollbackSQLStep
bot2-harness
force-pushed
the
dbops-1363
branch
from
798d5ca to
38520f8
Compare
4 participants
Onboarding two new static steps, LiquibaseUpdateSQLStep & LiquibaseRollbackSQLStep