gohcl: skip encoding additional nil fields#526
Open
jedevc wants to merge 1 commit intohashicorp:mainfrom
Open
Conversation
2d7a781 to
0de7ac6
Compare
This patch skips encoding nil slices, maps and interfaces, in addition to the already skipped nil pointers. Signed-off-by: Justin Chadwell <me@jedevc.com>
Author
|
Is there anything currently blocking this? |
|
I think the change does a good thing. Any chance it can be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch skips encoding nil slices, maps and interfaces, in addition to the already skipped nil pointers.
The scenario I've run into this in is something like the following:
Without the patch I get:
While with the patch, I get:
Hopefully this small change is something worth incorporating!