Fix incorrect byte check in NewRangeScannerFragment#611
Open
wata727 wants to merge 1 commit intohashicorp:mainfrom
Open
Fix incorrect byte check in NewRangeScannerFragment#611wata727 wants to merge 1 commit intohashicorp:mainfrom
wata727 wants to merge 1 commit intohashicorp:mainfrom
Conversation
wata727
force-pushed
the
fix_range_scanner_fragment
branch
from
b92720b to
d8cab2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
RangeScanner.Scan()implementation does not expect a fragment, and passing anything other than the initial position will end the scan without consuming anything.This PR adds a start position to
RangeScannerto allow proper byte checking.