Open
Conversation
The test report log contains the actual output emitted by the test-suite in a given Cabal package. The test log only contains the logs of the *build* of the test.
Contributor
|
this looks good to me. @bgamari i think we'll need to deploy the builder and the main hackage in sync for this... when you get time, take a look and then we can coordinate? |
Member
Author
|
I tried testing the migration locally, and I am getting an error with Acid.Core "too few bytes". So there must be some problem with this PR, or maybe it is exposing an existing issue... I will report back if I find out what the problem is. I think I'll try to write a unit test for this. |
Member
Author
|
I've done some migration testsusing the following REPL code: I still haven't discovered any issues... |
Member
Author
|
@gbaz Do you have any ideas for how to advance this? I'd be curious to know if you can reproduce my issue with your local instance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test report log contains the actual output emitted by the test-suite
in a given Cabal package.
The test log only contains the logs of the build of the test.
Fixes #1397.
Demo
These were the logs as emitted by
cabal run exe:hackage-build -- build testpkg -v:Cabal file fragment:
Main.hs (of test-suite) contents: