Add progress reporting support to cabal building#436
Open
palas wants to merge 5 commits intohaskell:masterfrom
Open
Add progress reporting support to cabal building#436palas wants to merge 5 commits intohaskell:masterfrom
palas wants to merge 5 commits intohaskell:masterfrom
Conversation
fendor
requested changes
Jul 3, 2024
Collaborator
fendor
left a comment
fendor
left a comment
There was a problem hiding this comment.
Hi, thank you for your PR!
I like the improved progress reporting, a couple of suggestions!
Collaborator
|
Look like a good feature to me. It is possible to add a unittest for it ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a tiny parser to
readCabalProcessWithProgressand it takes a new reporting function as a parameter that can be used to notify the caller about the progress of the building (how many dependencies to build and how many have been built so far). The motivation is to support HLS on this issue: #405