add nicer interface to control debug print#52
Open
supersonic-copycat wants to merge 1 commit intohdbc:masterfrom
Open
add nicer interface to control debug print#52supersonic-copycat wants to merge 1 commit intohdbc:masterfrom
supersonic-copycat wants to merge 1 commit intohdbc:masterfrom
Conversation
I used debug print to fix bug, but it was just unfriendly to edit sources of library to enable/disable debug print. So, I add couple of flags for this. `hdbcLog` is never used in codebase, confirmed by grep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, logging functions in
Database.HDBC.ODBC.Logare 'no-op', but to enable them you need to edit sources of library. This is just unfriendly way to enable/disable debug print. So, I add couple of flags to controlhdbcLogandhdbcTracebehaviour.Also I found that
hdbcLogis never used in codebase, but I add flag for it anyway.