Develop to master - fix to clean ambassador pod logs#95
Merged
pj-linebaugh merged 5 commits intomasterfrom Jul 22, 2025
Merged
Conversation
add sidecar container to run logrotate for ambassador log
Collaborator
|
hmm. should this also a chart version update? |
Contributor
Author
|
I believe that is automated with github actions. If it is not then I'll do it manually and/or bug Josh. |
Collaborator
|
Version bumping was a can of worms last time I looked at it, I actually removed it from the charts that had it. Could circle back but at this time it's a manual change. |
Contributor
Author
|
Good call @waTeim , I'll update the version. |
Contributor
Author
|
I've incremented the chart patch versions for helx-chart and ambassador. |
joshua-seals
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix cleans out the ambassador logs periodically so the pod does not use all it's ephemeral storage quota and is restarted.