changed console.log to openNotification.. when refering to API calls#309
Open
pchachicho wants to merge 1 commit intodevelopfrom
Open
changed console.log to openNotification.. when refering to API calls#309pchachicho wants to merge 1 commit intodevelopfrom
pchachicho wants to merge 1 commit intodevelopfrom
Conversation
Collaborator
|
@pchachicho sorry it took so long for me to get to this. this pr is on the right track, but there are a lot of other usages of the workspaces API throughout the UI components (for reference). Some of these don't need error messages (e.g. in app-card, we don't need to show a message if the app fails, since that's handled elsewhere) but the majority do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.