Conversation
Contributor
|
I don't think removing the download+unpack functionality entirely is a good idea, but it might be worth it to put it behind a feature flag (and pass an appropriate environment variable into the |
Member
Author
|
I added justification for this change to the PR description. Why do you think this is not a good idea exactly?
I don't think that's possible. |
6193d03 to
827ca99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes downloading and unpacking external kernel sources from the hermit wrapper crate. This means that the Hermit wrapper crate will no longer be published on crates.io but will need to be used via git.
Users will need to upgrade like this:
Comparison
This was tested in hermit-os/hermit-rs-template#88:
Evaluation
Downsides
Upsides