Open
Conversation
fix bug: get databases of mongo through ssh tunnel
LeoQuote
requested changes
May 18, 2024
Collaborator
There was a problem hiding this comment.
有过多重复的 conn.close , 如果想避免过多的重复连接, 请参考 mysqlengine 的做法
Lines 932 to 935 in 14fbd5e
然后做一个公用的 query 方法, 内部逻辑为, 获取连接, 做查询, 支持一个 close 参数, 如果 close 为 True, 则在查询后将连接关闭, 其他方法复用该方法, 这样可以使得代码更加简洁
隧道关闭应该不需额外声明, Engine base 内定义了
Archery/sql/engines/__init__.py
Lines 45 to 49 in 14fbd5e
应该会在view 退出时端口连接, 不会造成连接泄露
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复问题:
#2546