Skip to content

Add --tls option to dash command#1073

Merged
kamikazechaser merged 2 commits intohibiken:masterfrom
thomas4019:dash-cli-support-tls-option
Nov 10, 2025
Merged

Add --tls option to dash command#1073
kamikazechaser merged 2 commits intohibiken:masterfrom
thomas4019:dash-cli-support-tls-option

Conversation

@thomas4019
Copy link
Contributor

The current TLS options are insufficient to be able to easily connect to an AWS Redis instance with TLS enabled. In this PR, I'm adding a --tls argument which works the same way as the redis-cli, when specified it connects over TLS, but doesn't specify any of other TLS settings.

@kamikazechaser kamikazechaser added pr-feat pr-alternative-available There is a workaround this issue with minimal work labels Nov 4, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.34%. Comparing base (4f00f52) to head (46b7db1).
⚠️ Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1073      +/-   ##
==========================================
- Coverage   67.13%   63.34%   -3.80%     
==========================================
  Files          29       29              
  Lines        4300     4984     +684     
==========================================
+ Hits         2887     3157     +270     
- Misses       1135     1549     +414     
  Partials      278      278              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kamikazechaser kamikazechaser merged commit ff887e1 into hibiken:master Nov 10, 2025
9 of 10 checks passed
kamikazechaser pushed a commit that referenced this pull request Feb 3, 2026
* Add --tls option to dash command

* Switch order so it works better when both --tls and --tls_server are set
kamikazechaser added a commit that referenced this pull request Feb 3, 2026
* pre-release: v0.26.0

* deps upgrades
* min go version set to 1.24.0

* feat: done add-username-cli (#1083)

* Feature: Add Headers Support to Tasks (#1070)

* feat(task): Add headers support to tasks

* fix: cleanup copy map code

* fix: Add tests

* Add --tls option to dash command (#1073)

* Add --tls option to dash command

* Switch order so it works better when both --tls and --tls_server are set

* docs: update CHANGELOG

---------

Co-authored-by: Artemii Kulikov <91570054+vlle@users.noreply.github.com>
Co-authored-by: Joe <85931983+joejoe-am@users.noreply.github.com>
Co-authored-by: Thomas Hansen <th4019@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-alternative-available There is a workaround this issue with minimal work pr-feat

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants