Refactoring set#1143
Open
shahrajsingh wants to merge 2 commits intohneemann:masterfrom
Open
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #1143 +/- ##
========================================
Coverage 56.5% 56.6%
- Complexity 6571 6576 +5
========================================
Files 679 679
Lines 35494 35503 +9
Branches 4792 4792
========================================
+ Hits 20082 20099 +17
+ Misses 14202 14196 -6
+ Partials 1210 1208 -2
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactored code to improve the readability of the code,
decomposed conditional in doLayoutNormal to new calculateMergerPositionY for improved readability
the new method has been added at line 62.
Renamed variable width to maxWidth for better readability in the doLayoutNormal method
this change has been added to line 78, and subsequent changes have been made to use the new change.
created a new method named containsNonVariableFragments(), which is called in doLayout() method at line 157 to improve code readability.