Fixed the Hamamatsu SLM functionality, no working close function#178
Open
philip-rk wants to merge 2 commits intoholodyne:mainfrom
Open
Fixed the Hamamatsu SLM functionality, no working close function#178philip-rk wants to merge 2 commits intoholodyne:mainfrom
philip-rk wants to merge 2 commits intoholodyne:mainfrom
Conversation
Collaborator
|
Hi @philip-rk , thanks much for testing this! I added a few changes, including a I was wondering if you could test the following:
|
Collaborator
|
Oh, also, could you list the model of SLM you're using for testing? (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented a couple minor changes in order to use the Hamamatsu SLM via USB.
In order:
I tried simply wrapping the _Close_Device() function, but that didn't completely work, i.e. I couldn't reopen the slm.
I also replaced line 176 [array = display.astype(c_uint8) # TODO: check if this is necessary] with [array = display] and it seems like the conversion isn't necessary. From what I've seen it doesn't even convert the data-type anyway.