WIP: imp board: exclude packages from STEP export#722
Draft
eqvinox wants to merge 2 commits intohorizon-eda:masterfrom
Draft
WIP: imp board: exclude packages from STEP export#722eqvinox wants to merge 2 commits intohorizon-eda:masterfrom
eqvinox wants to merge 2 commits intohorizon-eda:masterfrom
Conversation
Loading STEP files into some other CAD software can take quite some time depending on the complexity of the STEP file. A board with a lot of vias takes several minutes to load into FreeCAD. While 3D component models can be excluded (worst case even by deleting individual ones after export, like all bypass caps), editing the board itself is not that easy since it is one single 3D object. This adds a STEP export setting to exclude all holes/vias below a given diameter. (Generally speaking, while larger holes can be important to have in the STEP export, there's generally some cut off below which you don't care, like 1mm.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WORK IN PROGRESS / DRAFT.
As discussed in #720, a way to exclude some packages from STEP export.
after coding this I realized it doesn't need the 2 treeviews with ← / → buttons… one treeview with checkboxes would be perfectly fine. after is always when you realize these things, I guess.
Out of time for now, not sure when I can redo it with checkboxes instead of 2 treeviews. Leaving it here as a draft for now 😄